github-actions[bot] wrote:
<!--LLVM IDS CHECK COMMENT-->
:warning: LLVM ABI annotation checker, ids-check found issues in your code.
:warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git diff origin/main HEAD -- 'llvm/include/llvm/**/*.h'
'llvm/include/llvm-c/**/*.h' 'llvm/include/llvm/Demangle/**/*.h'
Then run idt on the changed files with appropriate --export-macro and
--include-header flags.
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from ids-check here.
</summary>
``````````diff
diff --git a/llvm/include/llvm/IR/User.h b/llvm/include/llvm/IR/User.h
index da886a508..d68414c89 100644
--- a/llvm/include/llvm/IR/User.h
+++ b/llvm/include/llvm/IR/User.h
@@ -18,6 +18,7 @@
#ifndef LLVM_IR_USER_H
#define LLVM_IR_USER_H
+#include "llvm/include/llvm/Support/Compiler.h"
#include "llvm/ADT/iterator.h"
#include "llvm/ADT/iterator_range.h"
#include "llvm/IR/Use.h"
@@ -142,7 +143,7 @@ protected:
protected:
// Use deleteValue() to delete a generic User.
- ~User();
+ LLVM_ABI ~User();
public:
User(const User &) = delete;
diff --git a/llvm/include/llvm/Support/BranchProbability.h
b/llvm/include/llvm/Support/BranchProbability.h
index 61a032813..55c26b119 100644
--- a/llvm/include/llvm/Support/BranchProbability.h
+++ b/llvm/include/llvm/Support/BranchProbability.h
@@ -13,6 +13,7 @@
#ifndef LLVM_SUPPORT_BRANCHPROBABILITY_H
#define LLVM_SUPPORT_BRANCHPROBABILITY_H
+#include "llvm/include/llvm/Support/Compiler.h"
#include "llvm/ADT/ADL.h"
#include "llvm/Support/Compiler.h"
#include "llvm/Support/DataTypes.h"
@@ -101,7 +102,7 @@ public:
LLVM_ABI uint64_t scaleByInverse(uint64_t Num) const;
/// Compute pow(Probability, N).
- BranchProbability pow(unsigned N) const;
+ LLVM_ABI BranchProbability pow(unsigned N) const;
BranchProbability &operator+=(BranchProbability RHS) {
assert(N != UnknownN && RHS.N != UnknownN &&
diff --git a/llvm/include/llvm/Support/SourceMgr.h
b/llvm/include/llvm/Support/SourceMgr.h
index 43f7e27c2..a7ff4b1d2 100644
--- a/llvm/include/llvm/Support/SourceMgr.h
+++ b/llvm/include/llvm/Support/SourceMgr.h
@@ -15,6 +15,7 @@
#ifndef LLVM_SUPPORT_SOURCEMGR_H
#define LLVM_SUPPORT_SOURCEMGR_H
+#include "llvm/include/llvm/Support/Compiler.h"
#include "llvm/ADT/IntrusiveRefCntPtr.h"
#include "llvm/ADT/SmallVector.h"
#include "llvm/Support/Compiler.h"
@@ -106,14 +107,14 @@ public:
LLVM_ABI SourceMgr();
/// Create new source manager with the capability of finding include files
/// via the provided file system.
- explicit SourceMgr(IntrusiveRefCntPtr<vfs::FileSystem> FS);
+ LLVM_ABI explicit SourceMgr(IntrusiveRefCntPtr<vfs::FileSystem> FS);
SourceMgr(const SourceMgr &) = delete;
SourceMgr &operator=(const SourceMgr &) = delete;
- SourceMgr(SourceMgr &&);
- SourceMgr &operator=(SourceMgr &&);
+ LLVM_ABI SourceMgr(SourceMgr &&);
+ LLVM_ABI SourceMgr &operator=(SourceMgr &&);
LLVM_ABI ~SourceMgr();
- IntrusiveRefCntPtr<vfs::FileSystem> getVirtualFileSystem() const;
+ LLVM_ABI IntrusiveRefCntPtr<vfs::FileSystem> getVirtualFileSystem() const;
LLVM_ABI void setVirtualFileSystem(IntrusiveRefCntPtr<vfs::FileSystem> FS);
/// Return the include directories of this source manager.
``````````
</details>
https://github.com/llvm/llvm-project/pull/174892
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
