JustinStitt wrote:

@AaronBallman 
> That's what I was envisioning as well


After removing the flag and running the test I now believe that we should keep 
the flag but just have it on by default. This is because there's a WHOLE BUNCH 
of llvm IR tests that are not expecting to see my `srcloc` metadata and I'd 
love to specify ``-fno-diagnostics-show-inlining-chain`` on those tests.

I guess the two options are 1) update all the tests, 2) add `-fno...` to them

Thoughts?

https://github.com/llvm/llvm-project/pull/174892
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to