================
@@ -91,6 +92,13 @@ void FasterStringFindCheck::check(const
MatchFinder::MatchResult &Result) {
"efficient overload accepting a character")
<< FindFunc
<< FixItHint::CreateReplacement(Literal->getSourceRange(), *Replacement);
+
+ if (getID() == "performance-faster-string-find")
+ diag(Literal->getBeginLoc(),
+ "performance-faster-string-find is deprecated and will be removed in "
+ "future release, consider using "
+ "performance-prefer-single-char-overloads",
+ DiagnosticIDs::Note);
----------------
localspook wrote:
AFAIK, with this approach, someone who just enables `performance-*` would still
see this message, even though they never mentioned the deprecated alias. They
would have to add `-performance-faster-string-find` to their config to silence
it, which is precisely what we don't want them to do. That's what I meant by
adding a deprecation message being tricky. It may just be too much effort.
https://github.com/llvm/llvm-project/pull/186946
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
