================
@@ -91,6 +92,13 @@ void FasterStringFindCheck::check(const
MatchFinder::MatchResult &Result) {
"efficient overload accepting a character")
<< FindFunc
<< FixItHint::CreateReplacement(Literal->getSourceRange(), *Replacement);
+
+ if (getID() == "performance-faster-string-find")
+ diag(Literal->getBeginLoc(),
+ "performance-faster-string-find is deprecated and will be removed in "
+ "future release, consider using "
+ "performance-prefer-single-char-overloads",
+ DiagnosticIDs::Note);
----------------
zeyi2 wrote:
I think it would be worthy adding some universal helper functions to achieve
this? IMO the ongoing `hicpp-` removal work may face the same problem.
My current thought is to remove the notes in this PR for now, and add them back
after we finish the helper in `ClangTidyDiagnosticConsumer`. WDYT?
https://github.com/llvm/llvm-project/pull/186946
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
