frutiger added inline comments.

================
Comment at: bindings/python/clang/cindex.py:320
+        return self._get_spelling()['offset']
 
     def __eq__(self, other):
----------------
compnerd wrote:
> Does it make sense to introduce two new properties `expansion` and `spelling` 
> and have the four fields be properties on those properties?  It seems like it 
> would be more pythonic.
I agree, but I was concerned about breaking existing users that might be using 
the expansion properties directly on this object.  Would marking them 
deprecated in the documentation suffice?


https://reviews.llvm.org/D37905



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to