compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
================
Comment at: bindings/python/clang/cindex.py:320
+ return self._get_spelling()['offset']
def __eq__(self, other):
----------------
frutiger wrote:
> compnerd wrote:
> > Does it make sense to introduce two new properties `expansion` and
> > `spelling` and have the four fields be properties on those properties? It
> > seems like it would be more pythonic.
> I agree, but I was concerned about breaking existing users that might be
> using the expansion properties directly on this object. Would marking them
> deprecated in the documentation suffice?
Yeah, I think thats a great approach.
https://reviews.llvm.org/D37905
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
