Seems fine, it would be nice if the workflow could be improved a little bit so that all you have to do is say `clangdiag break —error=“-Wcovered-switch”` or something . I think that gives the most intuitive usage for people, even it’s a bit harder to implement.
I also think user shouldn’t really have to concern themselves with diagtool, it should all just be magic. I get why it’s easier to do this way, but from the users perspective, having the commands map as closely as possible to the thing the person wants to do and hiding implementation details is a big win from a usability standpoint. We can iterate on it later though On Thu, Oct 26, 2017 at 2:38 PM Don Hinton via Phabricator < revi...@reviews.llvm.org> wrote: > hintonda updated this revision to Diff 120492. > hintonda added a comment. > > - Remove debugging print statement, and enhance help message. > > > https://reviews.llvm.org/D36347 > > Files: > utils/clangdiag.py > >
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
