https://github.com/NagyDonat requested changes to this pull request.
This PR doesn't appear to comply with our policy on tool-generated content, and requires additional justification for why it is valuable enough to the project for us to review it. Please see our developer policy on AI-generated contributions: http://llvm.org/docs/AIToolPolicy.html The new code may be correct (I didn't spot any glaring issues), but its placement happens to be so sloppy (no pun intended) that this clearly violates that _"Contributors must read and review all LLM-generated code [...]"_ – reviewing a change includes reading the immediate context of the insertion, and then you would have noticed that this is not a suitable place for inserting new code. This concrete issue is very easy to fix (just place the new code at either the beginning or the end of the function); but the main problem is the _attitude_ that you expect reviews from others (who are actually familiar with the codebase) without investing two minutes to read ten lines before and after the freshly written code. This violation is made more egregious by your comment that claims that you have read the AI Tool Use policy and you follow it. https://github.com/llvm/llvm-project/pull/227874 _______________________________________________ cfe-commits mailing list [email protected] https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
