mclow.lists added a comment.

In https://reviews.llvm.org/D41368#958865, @zturner wrote:

> It would be better if we could just fix the code.


I disagree (See discussion of https://reviews.llvm.org/D39149). Even if it was 
"just this one place" (which it isn't), this affects users of clang, not just 
libc++.
This is a (small, but significant) barrier to people trying to write correct, 
portable generic code, and clang is just wrong to warn here.

As an aside, I definitely object to "just fix the code". The code is correct as 
written.
I think what you mean is "it would be better if we could just tell the compiler 
to shut up"  (which is what you've proposed - but incompletely)


Repository:
  rCXX libc++

https://reviews.llvm.org/D41368



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to