lebedev.ri added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/AvoidGotoCheck.cpp:21
+AST_MATCHER(GotoStmt, isForwardJumping) {
+ return Node.getLocStart() < Node.getLabel()->getLocStart();
+}
----------------
Hm, on a second thought, i think this will have false-positive if the label and
the goto are on the same line, like
```
goto label; ; label: ;
```
I wonder we could **easily** compare accounting for the position in the line,
or it is not worth the extra complexity.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41815
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
