sammccall added inline comments.
================
Comment at: clangd/Protocol.h:80
struct Position {
+ Position() = default;
+ Position(int line, int character) : line(line), character(character) {}
----------------
I'd lean to making callers initialize field-by-field here rather than provide
constructors.
It's not terrible here (you can get it wrong, but only one way), but it's a
pattern that doesn't scale so well I think.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43230
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
