MaskRay added a comment. > Have you considered also allowing '.' and ' ' (space) as separators in the > request? Having additional separators doesn't really hurt complexity of the > implementation, but allows to switch between tools for different languages > easier.
I would suggest allowing patterns containing space to match text without space, e.g. pattern `a b` can match text `aB`. The initial character of each word in the pattern should be seen as a `Head` position. This behavior matches many fuzzy matching plugins used in Emacs and Vim. ================ Comment at: clangd/SourceCode.cpp:110 + +llvm::Optional<Location> offsetRangeToLocation(SourceManager &SourceMgr, + StringRef File, ---------------- May I ask a question about the conversion between SourceLocation and LSP location? When the document is slightly out of sync with the indexed version, what will be returned? Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
