yaxunl marked an inline comment as done.
yaxunl added inline comments.

================
Comment at: lib/Driver/ToolChains/Cuda.cpp:498-501
+    OptArgs.push_back(mcpustr);
+    OptArgs.push_back("-dce");
+    OptArgs.push_back("-sroa");
+    OptArgs.push_back("-globaldce");
----------------
yaxunl wrote:
> tra wrote:
> > This does not look like the right place to disable particular passes. 
> > Shouldn't it be done somewhere in LLVM?
> These are not disabling the passes but adding these passes. They are some 
> optimizations which are usually improving performance for amdgcn.
Since opt is now able to adjust passes based on -mtriple and -mcpu, will remove 
these manually added passes and add -mtriple and -mcpu instead.


https://reviews.llvm.org/D45212



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to