mikhail.ramalho added a subscriber: rsmith. mikhail.ramalho added a comment.
Hi, > Or is the that whenever there's a `#line` directive we get into a > "virtual" file that's not registered in the `SourceManager`? The virtual file is actually registered in the SourceManager but the FileEntry for it is NULL (USRGeneration.cpp:33), which forces printLoc to return true (USRGeneration.cpp:38) and the USR is not generated. I believe the USR gen for params should have follow the functionDecl convention. I'm reworking the patch now. > int func(int param1); > int func(int param2); > // param1 and param2 could both have the same USR, but different names. > That might (or might not) be surprising. I agree here, they should have the same USR. Repository: rC Clang https://reviews.llvm.org/D42966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
