Hi Mario!

Thanks for the feedback! I'll be fixing the minor issues when I have time.

As for the hang... yeah, damn. That's a bug I THOUGHT I had fixed but 
apparently not. It's weird that it only happens with pub-sub, and only 
sometimes. If anyone knows what might be going on hmu, help is immensely 
appreciated.

I'll try re-submitting again after the issues are fixed.

Thanks again! Cheers.


El 31 de octubre de 2021 7:03:20 a. m. GMT-03:00, Mario Domenech Goulart 
<ma...@parenteses.org> escribió:
>Hi Ariela,
>
>On Fri, 29 Oct 2021 13:35:52 -0300 Ariela Wenner <aris...@disroot.org> wrote:
>
>> Hi all! I'd like to add my nng egg to the coop. Went through test-new-egg 
>> and everything seems fine.
>>
>> Release info is at 
>> https://gitlab.com/ariSun/chicken-nng/-/raw/main/nng.release-info
>>
>> Wiki page is http://wiki.call-cc.org/eggref/5/nng
>>
>> This is the first time I publish an egg so please let me know if something's 
>> wrong.
>
>Thanks!  That looks very interesting.
>
>I've tried to test your egg as part of the setup procedure of our test
>machines and stumbled upon a couple of issues.  I'm using the following
>environment:
>
>* Debian 10.11
>* GCC 8.3.0
>* x86 system (32bit)
>* CHICKEN 5.2.0
>* nng version 1.5.2
>
>I'm able to compile and install the egg, but when I run tests I get
>
>  csi: symbol lookup error: .../lib/chicken/11/nng.so: undefined symbol: 
> pthread_mutexattr_init
>
>I can work around that by using
>
>diff --git a/nng.egg b/nng.egg
>index 782ce6c..f5b4f9a 100644
>--- a/nng.egg
>+++ b/nng.egg
>@@ -5,6 +5,6 @@
>  (test-dependencies test uuid)
>  (dependencies foreigners srfi-18 srfi-69)
>  (components (extension nng
>-                        (csc-options "-L" "-lnng")
>+                        (csc-options "-L" "-lnng" "-L" "-lpthread")
>                         (source "src/nng.scm")))
>  (version 0.2.0))
>
>
>But then tests apparently hang in "tcp pub-sub":
>
>-- testing nng ---------------------------------------------------------------
>non-blocking ......................................................... [ PASS]
>tcp req-rep .......................................................... [ PASS]
>inproc req-rep ....................................................... [ PASS]
>tcp push-pull ........................................................ [ PASS]
>inproc push-pull ..................................................... [ PASS]
>tcp pair ............................................................. [ PASS]
>inproc pair .......................................................... [ PASS]
>tcp pub-sub .......................................................... 
>
>strace doesn't help much:
>
>$ strace -p 19841
>strace: Process 19841 attached
>restart_syscall(<... resuming interrupted poll ...>
>
>Would you know what can be wrong?
>
>Regarding the documentation, a few notes:
>
>* Please use the actual egg name as main heading (s/chicken-nng/nng/)
>
>* It would be nice to mention which versions of nng the egg is supposed
>  to be compatible with.  At least the versions it is known to work with.
>
>* Please add the following sections to the documentation:
>  * a "Repository" section with a link to the source repository
>  * a "License" section mentioning the license of the egg (should match
>    what's specified in the .egg file
>
>All the best.
>Mario
>-- 
>http://parenteses.org/mario
>

-- 
Ariela Wenner

Reply via email to