Actually, they sync to whatever rev they are being told. So roughly:1.
gclient revert
2. gclient sync --revision
3. patch
4. if a DEPS file changed: gclient sync --revision  (again)
5. gclient runhooks

I forgot if runhooks is always run or not. The fact that the .vcproj files
are clobbered and regenerated at each build slows down the slaves
_significantly_. I don't know the best way to solve that.

M-A

On Tue, Mar 17, 2009 at 7:01 PM, Bradley Nelson <bradnel...@google.com>wrote:

> I think I see what's happening.maruel, do I understand correctly that the
> trybot syncs to the revision the patch is based on before applying it? It
> looks like when folks with patchs prior to the base-gyp switch do a try,
> that it rolls things back, which doesn't work right.
> If folks sync before try the issue should go away.
>
> Alternatively, I had given some thought to how the trybot could handle
> gyp<->vcproj changes.
> Currently gclient is run, which runs gyp, then the patch is applied.
> Ideally, gclient would be run without invoking gyp, then patch is applied,
> then gyp is run. I had assumed since this is a temporary transition, that we
> don't care to make this work, as everything will be fine after gyp is fully
> deployed.
>
> -BradN
>
>
> On Tue, Mar 17, 2009 at 3:10 PM, Marc-Antoine Ruel <mar...@chromium.org>wrote:
>
>> It randomly happen on windows try slave every day.
>>
>>
>> On Tue, Mar 17, 2009 at 2:41 PM, Bradley Nelson <bradnel...@google.com>wrote:
>>
>>> Did this ever get resolved?I'd be eager to hear about any trouble with
>>> gyp.
>>>
>>> -BradN
>>>
>>>
>>> On Mon, Mar 16, 2009 at 5:44 PM, Jim Roskind <j...@chromium.org> wrote:
>>>
>>>> Just a wild guess... please ignore if this is not applicable:
>>>>
>>>> Any chance you pulled on Friday eve between 5pm and 8pm pacific time?
>>>>  If so, you might have gotten your tree a little wedged.  When you do a
>>>> gclient sync, does it "skip" any of the files because there is a gyp
>>>> generated file in the way (file not under svn control!!!)?
>>>> IF you got a pull from this broken point, you need to a) gclient sync
>>>> (as best as you can); b) delete the potentially bogus sln files (that are
>>>> gettting skipped); c) gclient sync again (to get working copies from SVN.
>>>>
>>>> YMMV.
>>>>
>>>> Jim
>>>>
>>>>
>>>> On Mon, Mar 16, 2009 at 5:39 PM, Tong Wu <gutongsedeyo...@gmail.com>wrote:
>>>>
>>>>> Need to run GPY as Bradley mentioned before? I did not try the latest
>>>>> build.
>>>>> On Wed, Mar 11, 2009 at 9:09 PM, Bradley Nelson <bradnel...@google.com>
>>>>> wrote:
>>>>> > Hi All,
>>>>> > I've just rolled out a switchover of several components on Windows to
>>>>> > gyp (generate your project),
>>>>> > the new cross platform build tool to which chromium is migrating.
>>>>> > gyp is now the official build tool for mac.
>>>>> > Consider this a trial period for windows.
>>>>> > IF THE ARE PROBLEMS, PLEASE LET ME KNOW!
>>>>> > This change affects the following modules:
>>>>> > base
>>>>> > icu38
>>>>> > zlib
>>>>> > libpng
>>>>> > libjpeg
>>>>> > gtest
>>>>> > If you are just building these components, everything should work as
>>>>> it did
>>>>> > before.
>>>>> > vcproj files will be generated at checkout.
>>>>>
>>>>>
>>>>> On Tue, Mar 17, 2009 at 7:45 AM, Nicolas Sylvain <
>>>>> nsylv...@chromium.org> wrote:
>>>>>
>>>>>> How did you get the code? Tarball? Svn? Gclient?
>>>>>> Nicolas
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> On Mon, Mar 16, 2009 at 2:38 AM, zyn <njred...@163.com> wrote:
>>>>>>
>>>>>>>
>>>>>>> Can't build the latest chrome,what's wrong with it.I use vs2005 to
>>>>>>> open the chrome.sln,it complains a lot of vcproj file missing.When
>>>>>>> build the solution,it failed.I was successfully build early chrome
>>>>>>> build.Is there something i do wrong,Can some one give me a hint?
>>>>>>>
>>>>>>> Thank you!
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>> >>>
>>>
>>
>

--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com 
View archives, change email options, or unsubscribe: 
    http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---

Reply via email to