On Tue, Mar 17, 2009 at 9:28 PM, Mark Mentovai <m...@chromium.org> wrote:
> Marc-Antoine Ruel wrote:
> > They are not svn:ignored.
>
> OK, anything that's GYP-generated does need to be in svn:ignore.
>
Not understanding why?
>
> > One of the thing I'm afraid of is that even if a
> > generated .vcproj is patched, it wouldn't be fixed on next try.
>
> If a (bad!) patch that's sent to a try server touches a .vcproj (or
> .sln or .xcodeproj or anything else GYP-generated), under the current
> system, it wouldn't be fixed on the next "try" unless a .gyp file
> changed for the next try or the next patch to run touched a .gyp file.
>
> We can overcome this by using runhooks --force on the try servers. We
> currently use runhooks without the --force.
>
That sounds right.
>
> > At the same time, I'd like GYP to _not_ overwrite a generated file if it
> > hasn't changed. This way, a full rebuild wouldn't be triggered.
>
> The Xcode generator works by writing new project files under temporary
> names next to the real project files, and then essentially running
> "diff" and renaming the project file to the real name if appropriate.
> I don't think any other generator currently does this, but the VS one
> probably should.
>
I've made a note to add this tomorrowish, I recall we discussed it, but it
slipped through the cracks.
>
> Mark
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
