That would be awsome...
I just uploaded the patch here:
http://codereview.chromium.org/108040
BYE
MAD
On Tue, May 5, 2009 at 5:14 PM, Mike Pinkerton <pinker...@chromium.org>wrote:
> I was able to get very consistent results before with just TestShell
> on Mac running the mozilla page-cycler test locally. Would using
> TestShell instead of Chromium help, or do you want me to try your
> patch on Mac?
>
> Let me know.
>
> On Tue, May 5, 2009 at 2:08 PM, Marc-Andre Decoste <m...@chromium.org>
> wrote:
> > Salut,
> > I've been trying to locally collect performance data to confirm
> whether
> > this was a good enough improvement or not and I can't seem to get
> consistent
> > enough results on my machine to draw a conclusion... Some things look
> > faster, and others look slower, but I sometimes get faster results with
> the
> > resize corner enabled, compare to disabled (which doesn't really make
> > sense)... So I don't think I can rely on these numbers...
> > So I decided that I will go through with the code review of the
> changes,
> > and if Adam and Darin are happy with it, I will commit and monitor the
> > performance dashboard to see how it goes there... If it goes bad, I'll
> > revert... And if it goes well... I'll scream my happiness as loud as I
> can
> > (and those who know me a bit, know that I CAN be pretty LOUD!!! ;-)...
> > BYE
> > MAD
> >
> > On Fri, May 1, 2009 at 1:00 PM, Adam Langley <a...@chromium.org> wrote:
> >>
> >> On Fri, May 1, 2009 at 9:06 AM, Marc-Andre Decoste <m...@chromium.org>
> >> wrote:
> >> > Salut Evan,
> >> > thanks, I will do that... And the results seems better than I
> >> > initially
> >> > thought...
> >>
> >> If you get performance improvements, please do commit :)
> >>
> >> Evan is correct that Darin needs to check this over, but I'll happy
> >> code review everything where I can.
> >>
> >>
> >> AGL
> >
> >
>
>
>
> --
> Mike Pinkerton
> Mac Weenie
> pinker...@google.com
>
--~--~---------~--~----~------------~-------~--~----~
Chromium Developers mailing list: chromium-dev@googlegroups.com
View archives, change email options, or unsubscribe:
http://groups.google.com/group/chromium-dev
-~----------~----~----~----~------~----~------~--~---
