On Wed, Jul 15, 2009 at 5:28 PM, Peter Kasting <pkast...@chromium.org>wrote:
> I am now working on this upstream at > https://bugs.webkit.org/show_bug.cgi?id=27323 . > I have just checked in some changes that should help a bit. Builds should get farther than before (I haven't fixed all issues here) because all shell scripts have been changed to use LF line endings. prepare-ChangeLog, svn-create-patch, and commit-log-editor all work now, except that I still have an outstanding review for a change to make svn-create-patch not get confused about where the repository root for WebKit is. svn-unapply and svn-apply seemed to work for me as-is on my very simple patch. Making use of commit-log-editor is harder than I expected. Simply setting SVN_EDITOR = commit-log-editor doesn't work the way it does with the cygwin svn; the Windows svn tries to run commit-log-editor from inside a Windows cmd environment, so you get "not a known command" because it's a perl script. For now I've hacked around this by placing a commit-log-editor.bat inside my third_party/WebKit, which contains: @echo off setlocal e:\cygwin\bin\perl.exe -Ie:\pkasting\svn\trunk\src\third_party\WebKit\WebKitTools\Scripts -w -- e:\pkasting\svn\trunk\src\third_party\WebKit\WebKitTools\Scripts\commit-log-editor %* (That's three lines, the third being long. Obviously you'd replace the paths here as relevant.) I have updated the instructions accordingly. PK --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
