(using the write from address) This sounds fine to me. It's like how we handle CRASH and TIMEOUT as special failures.
On Wed, Sep 23, 2009 at 12:44 PM, Dimitri Glazkov <dglaz...@chromium.org> wrote: > On Wed, Sep 23, 2009 at 12:33 PM, Ojan Vafai <o...@chromium.org> wrote: >> +pam, tc, darin in case they disagree with what I'm saying here. >> >> Also a bunch of current expectations would need to be modified. All >> the cases where there is currently FAIL would need to be changed to >> either FAIL or IMAGE or both if it's a text and image failure. You >> should be able to get most of the data for this by looking at the >> layout test dashboard. The only exception is you won't be able to >> distinguish tests that fail both image and text from tests that only >> fail image. >> >> A short-term solution could be to leave FAIL meaning IMAGE and/or TEXT >> and adding IMAGE and TEXT for image-only and text-only failures. Then >> we can gradually excise the FAIL lines from text_expectations. > > I think is a great plan. > > :DG< > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---