Thanks for taking on this feature! Some comments: > ChromeClientChromium will implement the > runJavaScriptRegisterProtocolHandler method in the > ChromeClientImpl class in webkit/glue/chrome_client_impl.h.
Are you sure you need to add this method to ChromeClientChromium? That interface is only to be used when the method doesn't exist on ChromeClient. Only supporting a whitelist of schemes sounds best to me. What does Firefox allow? Before you venture too far into the implementation, I'd like to see what the proposed WebKit API changes will be. This would be a good thing to add to your design doc. Thanks, -Darin On Thu, Sep 24, 2009 at 12:51 PM, <b...@chromium.org> wrote: > > I've shared a document with you: > > [HTML5] registerProtocolHandler API > > http://docs.google.com/Doc?docid=0AVgZ1iILHLkdZGQ0bjd6cTVfMGdqZmpiNGZr&hl=en&invite=CI6z8vgG > > It's not an attachment -- it's stored online at Google Docs. To open this > document, just click the link above. > > > This is a design document for the worked needed to resolve > http://crbug.com/11359 beyond the webkit implementation. > > Please feel free to comment inline or in this thread. I look forward to > your critics and suggestions. > > > > --~--~---------~--~----~------------~-------~--~----~ Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev -~----------~----~----~----~------~----~------~--~---
