On Wed, Dec 16, 2009 at 4:25 AM, Jeremy Moskovich <jer...@chromium.org>wrote:
> Hi Horonori, > > Thanks for taking a look at this!! > > What kinds of differences are you seeing without the new spellchecker > class? > > The only notable difference seems to be that the fonts are slightly > different vs. the expected output. > The fonts appear bolded in this case (to me). > > Where is the expected output coming from? What OS version are you running > this on? > > btw. The scrollbar diffs are to expected as we draw scrollbars differently > in Chrome than Safari does. > > Best regards, > Jeremy > > 2009/12/16 Hironori Bono (坊野 博典) <hb...@chromium.org> > > Greetings chromium-developers, >> >> Sorry for my beginner's question in advance. >> To fix a long-lasting issues: Issue 11577 (*1) and Issue 23497 (*2), I >> have implemented a MockSpellcheck class (*3), which is a mock >> implementation of our spell-checker used for layout tests. Even though >> this change can fix most layout-test failures listed in Issue 23497, >> there are a layout test that fails on an unknown reason, >> "editing/selection/unrendered-002.html". >> To run such tests on my Mac, our test_shell outputs very similar >> images as the expected one but actually different ones as shown in the >> attached pictures. Would it be possible to give me your thoughts about >> why our test_shell cannot create the expected image for this case? >> >> (*1) http://crbug.com/11577 >> (*2) http://crbug.com/23497 >> (*3) http://codereview.chromium.org/493003/show >> >> Best regards, >> >> Hironori Bono >> E-mail: hb...@chromium.org >> >> -- >> Chromium Developers mailing list: chromium-dev@googlegroups.com >> View archives, change email options, or unsubscribe: >> http://groups.google.com/group/chromium-dev > > > -- > Chromium Developers mailing list: chromium-dev@googlegroups.com > View archives, change email options, or unsubscribe: > http://groups.google.com/group/chromium-dev > -- Chromium Developers mailing list: chromium-dev@googlegroups.com View archives, change email options, or unsubscribe: http://groups.google.com/group/chromium-dev
