Johannes Sixt wrote:
> On Wednesday 07 March 2007 22:46, you wrote:
>>> Replacing Asset* in parameter lists by Asset& is certainly not worth it.
>>> You gain absolutely nothing, but only introduce a lot of unnecessary code
>>> changes. Please don't do that.
>> replaced Asset* with Asset_GC which is boost::shared_ptr, any yes that
>> are a lot of nessary code changes.
>>
>> Some of them can be reverted back to Asset& for performance reasons,
>> that is if the callee will only read them and not copy them, then
>> passing references is sane, they could be reverted to Asset* to but
>> since they already got modified once, i'd now prefer the transistion to
>> more sane references.
>
> With all these modifications do not forget, that we intend to merge from
> upstream again. Therefore, avoid those code changes at all costs that do not
> change (= improve) the behavior.
>
> Consequently, *I* will not include the modifications you currently have in
> your git in the SVN, because they make upstream merges more difficult than
> necessary.
Agreed, I didn't intended all my changes to be merged to the SVN main
trunk. Instead have to maintain my branch from now on. Unless HV merges
my changes, it will become difficult to merged into SVN. I'll try to
merge SVN regulary into my tree.
I stated, that this is just my personal experiment (in the same spirit
like HV works on cinelerra for his own purpose). I would really like if
some developers from CinelerraCV bless it as CinelerraCV_improved and
maybe create a branch in SVN (or just use git for collaboration), but
thats out of my control.
>
> The changes are of a kind that you will have to lobby at HV directly. And
> then
> you need a *very* good reason that they are an improvement. "References are
> more sane" will not be enough.
My repository it open and I like comments on it, nevertheless I'll hack
freely on what I want to have there. I can only invite others to review
it and maybe cherrypick from it. Decide yourself, I don't intend to make
a Lobbying campain.
If HV wants to collaborate more (opening his repository publically or to
some developers) I would really welcome it, he deserves my greatest
respect, Cinelerra is a incresible piece of software, but he decided to
do the releases as he does now and we have to take that. There is
nothing I can and want to do currently to improve merging with HV.
Christian
_______________________________________________
Cinelerra mailing list
Cinelerra@skolelinux.no
https://init.linpro.no/mailman/skolelinux.no/listinfo/cinelerra
