do not touch the ring of wagamoto Le lun. 13 mars 2023 à 08:23, Toshio Nakamura <tnakam...@openjdk.org> a écrit :
> On Thu, 26 Jan 2023 09:15:47 GMT, Toshio Nakamura <tnakam...@openjdk.org> > wrote: > > >> When JEditorPane shown HTML form with multi-selection, the reset > operation broke its data. > >> > >> The sample testcase were attached in JBS. The recreate steps are below: > >> 1. The sample shows a multi-selection form with 5 items. > >> 2. Select the 4th item. > >> 3. Press the reset button. > >> Actual: The 4th item is still selected. > >> Expect: No item should be selected. Resetting operation may move to the > initial state. The sample doesn't use 'selected' property in each option > tag. > >> 4. Just after the step 3, move the focus to outside of the application > and back. > >> Actual: The 2nd item is selected. It means inside data indicates so. > >> Expect: No item is selected. > >> > >> There are two issues. The current method > `OptionListModel.removeIndexInterval()` removed the indexed item, and > shifted the rest. Then, selection values were corrupted. > >> I think the clear selection method `OptionListModel.clearSelection()` > is suitable here. > >> > >> Test: jdk_desktop on macOS (x64, Monterey), Linux (x64, RHEL8), and > Windows (x64, 2012R2). > >> No regression found > > > > Toshio Nakamura has updated the pull request with a new target base due > to a merge or a rebase. The incremental webrev excludes the unrelated > changes brought in by the merge/rebase. The pull request contains five > additional commits since the last revision: > > > > - Update Copyright years > > - Merge branch 'master' into 8295248 > > - Fixed space > > - Update testcase > > - 8295248: JEditorPane HTML form with multi selection broke drawing > after reseting > > Ping for keeping this PR active. > Could you tell me what this PR is missing? > > ------------- > > PR: https://git.openjdk.org/jdk/pull/10685 >
