On Fri, 17 Mar 2023 04:24:42 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> 
wrote:

>> @azvegint In reference to the combobox's button, the email I got back from 
>> Apple says "in Aqua, there is no concept of a non editable Combo Box... what 
>> you are depicting as a JComboBox is actually a popup/pulldown". However, 
>> "NSComboBox, because of its direct affinity to NSTextField, has the square 
>> bezel corners" rather than "the softer rounded corners that the button 
>> family uses". My understanding from this is, since JComboBox relies on 
>> TextField, it uses the native TextField's square corners.
>
> I guess now in JDK with your testcase, popup button are shown opposite to 
> what native components shows ie editable combobox shows non-editable pop-up 
> button and non-editable combobox shows editable pull-down button
> 
>  
> ![image](https://user-images.githubusercontent.com/43534309/225811385-0aea444e-80b3-4608-8a19-31abddaa4501.png)
> 
> whereas in native for non-editable one we have pop-up
> ![image](https://user-images.githubusercontent.com/43534309/225811657-62c3f8c5-9ed2-4ad9-b291-48b55569c79b.png)
> and for editable we have pull-down
> ![image](https://user-images.githubusercontent.com/43534309/225812101-9939bd87-d3ef-4f1c-ac32-c5bd37ac647e.png)

This is because the test is set to test for isPopDown set to true, which 
changes the button appearance for non-editable to be a single down arrow. With 
this set to false, the button would match native. I have updated the test to 
test the native instead. Thanks.

For the editable comboboxes, the only button that is supported is the up and 
down arrow one shown. So, this one cannot be changed.

They now show as: 
<img width="199" alt="Screen Shot 2023-03-17 at 11 23 11 AM" 
src="https://user-images.githubusercontent.com/96267980/225987450-0ebd0c80-cbea-4601-88d8-3155616c3c0e.png";>

-------------

PR: https://git.openjdk.org/jdk/pull/12750

Reply via email to