On Tue, 1 Aug 2023 21:14:58 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
> we have similar typo in the BasicTreeUI.java as well. Yes, it's there: https://github.com/openjdk/jdk/blob/b093880acd89d8d0bccd4b8b260b721f4dcfc161/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java#L4084-L4088 Yet it's not visible *externally*, it's visible only to those who read the code of the `BasicTreeUI.Handler.handleSelection` method whereas the typo I'm addressing here is in the published API documentation for [`JFormattedTextField`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/JFormattedTextField.html). It wasn't my goal to amend [**all** the instances](https://github.com/search?q=repo%3Aopenjdk%2Fjdk%20%22it%20self%22&type=code)¹ where *‘it self’* is present in the code base — it takes much more time and effort². It was supposed to be a quick and trivial bug report and fix which addresses *this particular typo* in the single file, `JFormattedTextField.java`. A single file with ~~a single change~~ with four changed lines should've been reviewed quickly and smoothly. For what it's worth, we have spent much more time discussing it… ¹ There are quite a few; yet they're mostly in hotspot code comments. Eventually, all could be amended. ² I've been on this journey with [*‘a the’*](https://bugs.openjdk.org/browse/JDK-8284189) in various combinations, it took about two months since its inception to its completion. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15087#discussion_r1281973937
