On Fri, 29 Sep 2023 19:27:33 GMT, Alexey Ivanov <[email protected]> wrote:
>> Alisen Chung has updated the pull request incrementally with one additional >> commit since the last revision: >> >> fixed skippedexception, fixed comment > > test/jdk/javax/swing/ToolTipManager/bug5078214.java line 66: > >> 64: "with the taskbar at the bottom position."); >> 65: } >> 66: bounds = getGraphicsConfig().getBounds(); > > It's better to use the pattern that was used before: assign the result of > `getGraphicsConfig()` to `testConfig` because `getGraphicsConfig()` is not a > simple getter which returns the value of a field. On the other hand, it's > more like premature optimisation; it's unlikely that enumerating screens > takes a lot of time, especially now when you use the default config only. It's marked resolved but I can't see any related changes. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15875#discussion_r1344164215
