On Tue, 3 Oct 2023 22:41:37 GMT, Damon Nguyen <[email protected]> wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2 sets of 500 repeats on all OS's without a timeout.
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unnecessary delay. Modify delay amount. Add break.
test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 107:
> 105: System.err.println("Incorrect action during loop");
> 106: break;
> 107: }
Actually, I meant adding it as part of the condition in the for-loop itself.
However, it works either way.
The initial bug report for
[JDK-4774532](https://bugs.openjdk.org/browse/JDK-4774532) says `dragOver`
shouldn't be called at all. Do we want to update the test for a stricter
assertion. For me, `dragOver` is never called.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1345647800
