On Thu, 30 Nov 2023 10:52:18 GMT, Alexey Ivanov <[email protected]> wrote:

>> Tejesh R has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3013:
> 
>> 3011:             }
>> 3012:             //x position is updated to handled the offset to which the 
>> table
>> 3013:             //has to be moved towards right side in right-to-left 
>> Orientation.
> 
> Suggestion:
> 
>             // x position is updated to take into account the offset to
>             // which the table column is moved in the right-to-left 
> orientation.
> 
> I still don't like any variant because it doesn't clarify the main point: 
> _the columns are laid out starting from the right side_.

What about: _Table columns are laid out from right to left if component 
orientation is set to ComponentOrientation.RIGHT_TO_LEFT; adjust the x 
coordinate for this case._

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1410724356

Reply via email to