On Thu, 30 Nov 2023 12:37:37 GMT, Alexey Ivanov <[email protected]> wrote:

>> Tejesh R has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 9809:
> 
>> 9807:         }
>> 9808:         return super.getWidth();
>> 9809:     }
> 
> Can you elaborate on why it's needed? Presumably both versions return the 
> same width because `JTable` doesn't override `getWidth`.

I actually reused it from `JTableHeader` class and yeah it will be 
`parent.getWidth ` always as of now, but I thought it might be for future 
purpose, but not sure... Should we retain or just use `parent.getWidth` 
directly?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1410974627

Reply via email to