On Fri, 1 Dec 2023 09:26:41 GMT, Tejesh R <t...@openjdk.org> wrote:

>> Table contents does not follow right-left Orientation when Max width of 
>> columns are set. This is due to not considering the offset in `x position` 
>> while painting table grid and table cell. The fix handles the offset and 
>> adjust the x position for each paint, similar to how header is painted. The 
>> fix is applied to both Basic and Synth Look and Feel. 
>> The fix is verified for all Look and Feel manually and test verifies on 
>> Metal L&F since automatic test cannot be generalized throughout other Look 
>> and Feel. 
>> CI tested is green for regression check and test check.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review fix

Looks good now.

src/java.desktop/share/classes/javax/swing/JTable.java line 9804:

> 9802: 
> 9803:     }  // inner class AccessibleJTable
> 9804: 

You should preserve this blank line.

-------------

Marked as reviewed by aivanov (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16374#pullrequestreview-1759761739
PR Review Comment: https://git.openjdk.org/jdk/pull/16374#discussion_r1412073682

Reply via email to