On Mon, 22 Jan 2024 16:22:31 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> test/jdk/javax/swing/JFileChooser/FileSystemView/NoIconExeNPE.java line 264: >> >>> 262: FileSystemView fsv = FileSystemView.getFileSystemView(); >>> 263: // No NullPointerException is expected >>> 264: fsv.getSystemIcon(hello.toFile()); >> >> Maybe we should check that something useful is returned? at least non-null >> VS null value? > >> Maybe we should check that something useful is returned? at least non-null >> VS null value? > > Makes sense to ensure the returned value is not `null`. Sure. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17475#discussion_r1462417222
