On Mon, 22 Jan 2024 21:07:03 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Replaced asserts with NullPointerException calls because outside of testing >> that would be more informative - i do not think many people running their >> applications with assertions in system libraries enabled; >> Added a code that will analyze the result of the getIcon and will fall back >> to the default icon for the file type retrieved from the ShellFolder; >> Added a test case made by Aleksei Ivanov. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Fixed indentation > Test now checks for returned icon not to be null Marked as reviewed by aivanov (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/17475#pullrequestreview-1838527056
