On Thu, 18 Jan 2024 00:47:00 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
> Replaced asserts with NullPointerException calls because outside of testing > that would be more informative - i do not think many people running their > applications with assertions in system libraries enabled; > Added a code that will analyze the result of the getIcon and will fall back > to the default icon for the file type retrieved from the ShellFolder; > Added a test case made by Aleksei Ivanov. This pull request has now been integrated. Changeset: 6212264c Author: Alexander Zuev <kiz...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/6212264cc6fe428e8d15b7f33e2979c081e432d7 Stats: 282 lines in 2 files changed: 280 ins; 0 del; 2 mod 8320692: Null icon returned for .exe without custom icon Co-authored-by: Alexey Ivanov <aiva...@openjdk.org> Reviewed-by: aivanov ------------- PR: https://git.openjdk.org/jdk/pull/17475