On Wed, 13 Mar 2024 16:28:47 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Cleaned up five more tests. >> >> Continuation of https://github.com/openjdk/jdk/pull/18184 >> >> Unfortunately one of the commits rendered the whole PR invalid so i closed >> it and restarting it here. >> All comments from the previous review are addressed. > > test/jdk/javax/swing/JEditorPane/bug4325606.java line 80: > >> 78: robo = new Robot(); >> 79: } catch (AWTException e) { >> 80: throw new RuntimeException("Robot could not be created"); > > Suggestion: > > throw new RuntimeException("Robot could not be created", e); > > Preserve the original exception, which would be very helpful for debugging if > it ever occurs. Ok. > test/jdk/javax/swing/JEditorPane/bug4325606.java line 84: > >> 82: robo.setAutoDelay(100); >> 83: robo.delay(1000); >> 84: Point p = frame.getLocationOnScreen(); > > Technically, `getLocationOnScreen` should be called on EDT. It happens in the windowOpened method of the WindowAdapter. If window events arrive not on EDT then we have a whole other slew of problems :) ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523834899 PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1523842229
