On Wed, 13 Mar 2024 16:26:38 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>
>> Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>
> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 117:
>
>> 115: }
>> 116:
>> 117: class MyDesktopManager extends DefaultDesktopManager {
>
> Suggestion:
>
> private static class MyDesktopManager extends DefaultDesktopManager {
Done.
> test/jdk/javax/swing/JEditorPane/bug4325606.java line 101:
>
>> 99: } catch (BadLocationException blex) {
>> 100: passed = false;
>> 101: }
>
> Suggestion:
>
> } catch (BadLocationException blex) {
> throw new RuntimeException("Test failed", blex);
> }
>
> Throw exception preserving the original exception which will help analysing
> the failure?
Fixed.
> test/jdk/javax/swing/JEditorPane/bug4325606.java line 120:
>
>> 118: if (!b.passed) {
>> 119: throw new RuntimeException("Test failed.");
>> 120: }
>
> Suggestion:
>
> robot.waitForIdle();
>
> Wait until all events are processed. If test fails, it throws an exception on
> EDT; otherwise, the test is finished as soon as the event queue is empty. No
> need to waste 3 seconds.
Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524501718
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524502044
PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524502442
