On Thu, 14 Mar 2024 01:15:45 GMT, Alexander Zuev <kiz...@openjdk.org> wrote:
>> Cleaned up five more tests. >> >> Continuation of https://github.com/openjdk/jdk/pull/18184 >> >> Unfortunately one of the commits rendered the whole PR invalid so i closed >> it and restarting it here. >> All comments from the previous review are addressed. > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Update test/jdk/javax/swing/JDesktopPane/bug4773378.java > > Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com> test/jdk/javax/swing/JEditorPane/bug4325606.java line 100: > 98: Utilities.getRowStart(pane, pane.getCaretPosition()); > 99: } catch (BadLocationException blex) { > 100: throw new RuntimeException("Test failed."); Suggestion: throw new RuntimeException("Test failed.", blex); Preserve the original exception as it shows where the problem occurred. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18259#discussion_r1524520356
