On Thu, 14 Mar 2024 11:52:09 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
> Hi Reviewers,
>
> I have updated the test with PassFailJFrame with information panel, earlier
> this was informed through terminal.
> Please review and let me know your suggestions if any.
test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 43:
> 41: * @key printer
> 42: * @library /java/awt/regtesthelpers
> 43: * @build PassFailJFrame
Any reason why test summary is not there?
test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 45:
> 43: * @build PassFailJFrame
> 44: * @run main/manual/othervm -Djava.security.manager=allow
> SecurityDialogTest
> 45: */
Line spacing here would be nice.
test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
> 45: */
> 46: public class SecurityDialogTest extends Frame {
> 47: private static final String INSTRUCTIONS =
`INSTRUCTIONS` can be moved inside main.
test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 67:
> 65: }
> 66:
> 67: PassFailJFrame passFailJFrame = new PassFailJFrame.Builder()
I am getting an error for using new `PassFailJFrame passFailJFrame = new
PassFailJFrame.Builder()`, stating _"'Builder()' has private access in
'PassFailJFrame.Builder'"_ Probably because I have fetched latest
PassFailJFrame.
And also you can use `PassFailJFrame.builder()` method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525717301
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525717515
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525716495
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525721443
