On Fri, 15 Mar 2024 06:10:05 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> test/jdk/java/awt/print/PrinterJob/SecurityDialogTest.java line 47:
>>
>>> 45: */
>>> 46: public class SecurityDialogTest extends Frame {
>>> 47: private static final String INSTRUCTIONS =
>>
>> `INSTRUCTIONS` can be moved inside main.
>
> Most of the test with PassFailJFrame instruction stored as string inside
> class, what additional benefit will get keeping it inside Main ?
When it can become local variable then why to keep it in class? Not like
significant benefit maybe, but yeah just to keep its scope locally when it can
be.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18299#discussion_r1525822683
