On Mon, 22 Apr 2024 15:09:37 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Moved failure handling inside openThemeImpl method > > src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 117: > >> 115: if (theme == null || theme == 0) { >> 116: theme = openTheme(widget, defaultDPI); >> 117: } > > `theme` can't be `null` because `openTheme` returns `long`. Perhaps, the > declaration should be changed to > > long theme; > > > This is still incorrect. If `i > 0`, there's a prerequisite to calling > `openTheme`. Likely, you need another helper method. I didn't get the need for helper method? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18706#discussion_r1575758721