On Tue, 23 Apr 2024 07:11:30 GMT, Tejesh R <t...@openjdk.org> wrote:
>> src/java.desktop/windows/classes/sun/awt/windows/ThemeReader.java line 117:
>>
>>> 115: if (theme == null || theme == 0) {
>>> 116: theme = openTheme(widget, defaultDPI);
>>> 117: }
>>
>> `theme` can't be `null` because `openTheme` returns `long`. Perhaps, the
>> declaration should be changed to
>>
>> long theme;
>>
>>
>> This is still incorrect. If `i > 0`, there's a prerequisite to calling
>> `openTheme`. Likely, you need another helper method.
>
> I didn't get the need for helper method?
Ok, I got it. And I have updated. But if we want to change `theme` to `long`,
then I guess we have to do it every calling function I guess. So is it better
to leave it as `Long` ?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18706#discussion_r1576018740
