On Tue, 18 Jun 2024 06:21:12 GMT, Tejesh R <t...@openjdk.org> wrote:

>> Yes, modifying the shared `ActionMap` is causing this issue though. As far 
>> as I have seen the copy first solution is mentioned in this bug 
>> https://bugs.openjdk.org/browse/JDK-8166352 as customer submitted workaround.
>
> I did thought of few solutions for this issue:
> 1. To reset (If possible, but not sure how to do this, yet we have 
> `SwingUtilities.replaceUIActionMap`) the ActionMap. But when to reset is 
> again a question?
> 2. To consider what customer has suggested about making a copy and then using 
> that which again I'm not sure since here shared defaults are used from 
> BasicTableUI.
> 3. To remove the lines causing issue which I have proposed. I feel it is safe 
> now to remove it since TAB/ENTER functionalities (Basically TAB being moved 
> out of FilePane and ENTER on selecting file/opening Directory) is handled 
> without these lines too. I did CI test for any regression, but its look fine 
> without this lines too.

TAB navigation is prevented by this fix 
https://bugs.openjdk.org/browse/JDK-4835633 where the TAB is rejected in 
[this](https://github.com/openjdk/jdk/blame/a81e1bf1e1a6f00280b9be987c03fe20915fd52c/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTableUI.java#L683)
 line.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/19725#discussion_r1647807264

Reply via email to