On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R <t...@openjdk.org> wrote: >> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER >> functionalities to disable navigation within JTable of FilePane in >> DetailsView. This is causing the issue mentioned in the bug where on >> invoking DetailsView the functionalities are removed from JTable. I don't >> see it's effect/significance in disabling the navigation since the focus >> shifts outside the when TAB is presses and the folder opens when ENTER is >> pressed without this changed. >> I have tested the fix on CI system, its green. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix - remove null initialization for table
I think it is clear that modifying a shared map is a bad idea, so removing the code that is doing this is right. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/19725#pullrequestreview-2131313263
