On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval Marked as reviewed by aivanov (Reviewer). src/java.desktop/share/classes/javax/swing/plaf/basic/BasicSliderUI.java line 153: > 151: /** > 152: * Constructs a {@code BasicSliderUI}. > 153: * @deprecated This constructor will be removed in future release This needs a full stop at the end. It's usually added in `@deprecated` tags. Suggestion: * @deprecated This constructor will be removed in future release. Should we explain *why* it's deprecated? ------------- PR Review: https://git.openjdk.org/jdk/pull/19819#pullrequestreview-2132839628 PR Review Comment: https://git.openjdk.org/jdk/pull/19819#discussion_r1649072864
