On Fri, 21 Jun 2024 12:11:21 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> The no-arg constructor BasicSliderUI() was added under >> [JDK-8250852](https://bugs.openjdk.org/browse/JDK-8250852) by mistake. This >> constructor should be deprecated for removal in future release > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Add forRemoval > > I was under impression that BasicSliderUI(JSlider b) did use its parameter > > but it doesn't. > > > > Should we keep the new constructor and deprecate the _old_ one? > > I guess if we remove the old one, it might mean incompatibility to > applications which might be using it/calling it.. Even `createUI `uses this > JSlider param constructor This is why we *cannot* remove the old constructor with the parameter but we can deprecate it. The `createUI` method can use new no-arg constructor, and nothing will change. ------------- PR Comment: https://git.openjdk.org/jdk/pull/19819#issuecomment-2183068827