On Thu, 4 Jul 2024 12:59:48 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Julian Waters has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains five additional
>> commits since the last revision:
>>
>> - Formatting sizeof awt_Component.cpp
>> - Formatting awt_Component.cpp
>> - Merge branch 'openjdk:master' into patch-10
>> - Update src/java.desktop/windows/native/libawt/windows/awt_Component.cpp
>>
>> Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>> - 8334599
>
> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 3365:
>
>> 3363: }
>> 3364: static void
>> 3365: resetKbdState(BYTE (&kstate) [AwtToolkit::KB_STATE_SIZE]) {
>
> I don't know what is most used syntax for this type. I'd rather keep them
> together without a space between `()` and `[]`.
Will do
> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 3368:
>
>> 3366: BYTE tmpState[AwtToolkit::KB_STATE_SIZE];
>> 3367: WCHAR wc[2];
>> 3368: memmove(tmpState, kstate, sizeof (kstate));
>
> Suggestion:
>
> memmove(tmpState, kstate, sizeof(kstate));
>
> There's usually no space after `sizeof`.
Ah, seems awt follows a different convention from HotSpot, which I'm nmore used
to. I'll revert the formatting
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19798#discussion_r1673629959
PR Review Comment: https://git.openjdk.org/jdk/pull/19798#discussion_r1673630629
