On Fri, 28 Jun 2024 00:56:48 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Component.cpp line 3366:
>>
>>> 3364: static void
>>> 3365: resetKbdState( BYTE (&kstate)[256]) {
>>> 3366: BYTE tmpState[256];
>>
>> Suggestion:
>>
>> resetKbdState( BYTE (&kstate)[AwtToolkit::KB_STATE_SIZE]) {
>> BYTE tmpState[AwtToolkit::KB_STATE_SIZE];
>>
>> Will this resolve Phil's concern? Both arrays will use the same size.
>
>> Will this resolve Phil's concern? Both arrays will use the same size.
>
> @prrace Does this address your concerns? If it does I will commit it
That's fine since that what I was asking for in my comment a week ago
> Why can't we EVERYWHERE use the definition used to create the array passed in
> KB_STATE_SIZE = 256 instead of a mixture.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/19798#discussion_r1659284190
