On Fri, 16 Aug 2024 19:32:09 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> JFileChooser don't have the mnemonics for open and save button in GTK L&F. >> Fix is to add mnemonics for open and save button. >> Fix can be verified by Swingset2 demo application. Mnemonics in GTK L&F are >> visible once alt key is pressed. >> After running the SwingSet2 application, change the `L&F to GTK` and select` >> JFileChooser demo` from toolbar. Click on `Select Plain JFileChooser` button >> and then press alt key to verify the mnemonics. > > src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties > line 63: > >> 61: FileChooser.renameFileButton.textAndMnemonic=&Rename File >> 62: FileChooser.cancelButton.textAndMnemonic=&Cancel >> 63: FileChooser.saveButton.textAndMnemonic=Save > > Suggestion: > > FileChooser.saveButton.textAndMnemonic=&Save > > It looks like the Save button is the only button left in this file without a > mnemonic specified. Hmm, the `&S` is already used by FileChooser.pathLabel.textAndMnemonic=&Selection: It looks like that `&S` is more common for the save action, so probably we might want to change the `&Selection:` to something else, e.g. `S&election:` Any thoughts? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1720283148
