On Fri, 16 Aug 2024 19:45:19 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/resources/gtk.properties >> line 63: >> >>> 61: FileChooser.renameFileButton.textAndMnemonic=&Rename File >>> 62: FileChooser.cancelButton.textAndMnemonic=&Cancel >>> 63: FileChooser.saveButton.textAndMnemonic=Save >> >> Suggestion: >> >> FileChooser.saveButton.textAndMnemonic=&Save >> >> It looks like the Save button is the only button left in this file without a >> mnemonic specified. > > Hmm, the `&S` is already used by > > FileChooser.pathLabel.textAndMnemonic=&Selection: > > > It looks like that `&S` is more common for the save action, so probably we > might want to change the `&Selection:` to something else, e.g. `S&election:` > Any thoughts? mnemonics if gtk dialog were updated by the https://bugs.openjdk.org/browse/JDK-8080628, the save button was not changes since it is a default button in that dialog. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20612#discussion_r1720465815
