On Wed, 4 Jun 2025 19:51:11 GMT, Jeremy Wood <d...@openjdk.org> wrote:
>> Make sure AquaTextPasswordFieldUI can't use selectWordAction. >> >> The core problem here was we could call selectWordAction in the Aqua LAF on >> a JPasswordField. This problem was already solved in the >> BasicPasswordFieldUI and SynthPasswordFieldUI, but the >> AquaTextPasswordFieldUI does NOT extend the BasicPasswordFieldUI, so it >> wasn't inheriting this solution. >> >> So the problem is partially about multiple inheritance. >> >> My first response at solving the problem is just to move the existing >> solution to the parent BasicTextUI class and use an instanceof to make sure >> it is only applied to JPasswordFields. >> >> There may be many different philosophies/recommendations on how to resolve >> this; I'm open to suggestions. > > Jeremy Wood has updated the pull request incrementally with one additional > commit since the last revision: > > 8354646: run test on all available look and feels > > This is in response to: > https://github.com/openjdk/jdk/pull/25443#issuecomment-2933556752 test/jdk/javax/swing/plaf/basic/BasicPasswordFieldUI/PasswordSelectionWordTest.java line 76: > 74: return; > 75: } > 76: System.out.println("Testing "+ field.getUI()); Suggestion: System.out.println("Testing " + field.getUI()); ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25443#discussion_r2127432532
